svn commit: r198007 - user/eri/pf45/head/sys/contrib/pf/net
Julian Elischer
julian at elischer.org
Tue Oct 13 20:07:34 UTC 2009
John Baldwin wrote:
> On Monday 12 October 2009 6:26:10 pm Ermal LuXi wrote:
>> Author: eri
>> Date: Mon Oct 12 22:26:10 2009
>> New Revision: 198007
>> URL: http://svn.freebsd.org/changeset/base/198007
>>
>> Log:
>> * Prefix some other variables with V_ since their name is the same as
> their struct type.
>> * For being virtualization ready only contexes should be considered
> especially in event handlers.
>
> FWIW, I think it will be simpler to just have all virtualized variables start
> with V_ rather than having a partial mix. They should either all have V_ or
> none of them have V_ as anything else will just be confusing. And since the
> case of none of them having V_ doesn't compile that narrows it down. :)
>
Ermal, have you asked the OpenBSD guys if they'd accept any changes
from us that would make it easier?
The SCTP guys agreed to put "SCTP_GLOBAL(name)" around their globals
with the comment that it would help them in their user-land version.
I do know that OpenBSD agreeing to do something purely for someone
else would be a rather drastic departure from their normal M.O. but
you won't know until you ask.
Julian
More information about the svn-src-user
mailing list