svn commit: r185649 - in user/kmacy/HEAD_fast_multi_xmit/sys: net sys

[Kip Macy]

On Fri, Dec 5, 2008 at 2:11 PM, Andrew Gallatin <gallatin at cs.duke.edu> wrote:
> Kip Macy wrote:
>
>> Log:
>>  add inline helper functions for buf_ring enqueue and free
>
>> +       uint64_t                br_drops;
>
> Do you have any way to make these drops visible in netstat -id,
> or should driver writers regularly mirror br_drops
> into their ifp->if_snd.ifq_drops?

There will be an arbitrary number of buf_rings, so I think that
br_drops should be mirrored in to ifq_drops in the drivers callout.
Incrementing a shared counter on multiple cpus works but is not best
practice from a cache standpoint.


Thanks,
Kip