svn commit: r304070 - svnadmin/conf

Conrad Meyer cem at
Sun Aug 14 05:52:02 UTC 2016

On Sat, Aug 13, 2016 at 10:48 PM, Juli Mallett <juli at> wrote:
> On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber <gjb at> wrote:
>> Quoting the original request to remove this, which I tend to agree:
>> -------------------------- begin quoted text ---------------------------
>>  The svn commit mail script uses some form of 'diff -p' (or 'svn diff
>>  -x-p') to include function names at the top of each hunk.  The problem
>>  is that diff gets it wrong more often than not, especially (but not
>>  only) when functions are added or renamed, or outside a funciton, or in
>>  headers, or in code that makes heavy use of macros, or in files that
>>  aren't C-like source code: shell scripts, man pages, Makefiles...  All
>>  it really does is clutter up the patch and mislead the reader.
>> --------------------------- end quoted text ----------------------------
> :(
> I'm deeply skeptical that the described conditions add up to "more
> often than not," and that tangible harm is done in those cases,
> outweighing benefit added in the other, ostensibly rarer, case
> (changes in ordinary C source files, which are actually fairly
> abundant in FreeBSD.)

Exactly.  Yes, it gets it wrong sometimes.  But not enough to make it
more harmful than beneficial.


More information about the svn-src-svnadmin mailing list