svn commit: r343947 - stable/12/sys/kern

Konstantin Belousov kib at FreeBSD.org
Sun Feb 10 05:40:30 UTC 2019


Author: kib
Date: Sun Feb 10 05:40:28 2019
New Revision: 343947
URL: https://svnweb.freebsd.org/changeset/base/343947

Log:
  MFC r343724:
  Do not call PHOLD() while owning the allproc_lock sx.

Modified:
  stable/12/sys/kern/kern_proc.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/kern/kern_proc.c
==============================================================================
--- stable/12/sys/kern/kern_proc.c	Sat Feb  9 23:19:33 2019	(r343946)
+++ stable/12/sys/kern/kern_proc.c	Sun Feb 10 05:40:28 2019	(r343947)
@@ -3122,8 +3122,8 @@ allproc_loop:
 			PROC_UNLOCK(p);
 			continue;
 		}
-		_PHOLD(p);
 		sx_xunlock(&allproc_lock);
+		_PHOLD(p);
 		r = thread_single(p, SINGLE_ALLPROC);
 		if (r != 0)
 			restart = true;


More information about the svn-src-stable mailing list