svn commit: r355333 - stable/12/sys/cam

[Ian Lepore]

On Tue, 2019-12-03 at 11:54 -0500, Alexander Motin wrote:
> On 03.12.2019 11:47, Ian Lepore wrote:
> > On Tue, 2019-12-03 at 16:42 +0000, Alexander Motin wrote:
> > > Author: mav
> > > Date: Tue Dec  3 16:42:32 2019
> > > New Revision: 355333
> > > URL: https://svnweb.freebsd.org/changeset/base/355333
> > > 
> > > Log:
> > >   MFC r341756 (by scottl):
> > >   Don't allocate the config_intrhook separately from the softc,
> > > it's
> > > small
> > >   enough that it costs more code to handle the malloc/free than
> > > it
> > > saves.
> > > 
> > 
> > If it's a situation where the called hook routine always does a
> > disestablish of the hook (and nothing else does so), just use
> > config_intrhook_oneshot() and you don't need to manage the data
> > struct
> > yourself at all.
> 
> Right.  That is what I have done in my later commit.  The only downside
> of config_intrhook_oneshot() is that it require memory allocation unlike
> previous.
> 

Yeah, it's all about convenience rather than peformance.  Usually when
I need an intrhook it's a "one device instance once at bootup" kind of
thing where performance doesn't matter much.

-- Ian