svn commit: r283702 - stable/10/lib/libc/net

Michael Tuexen tuexen at FreeBSD.org
Fri May 29 11:21:35 UTC 2015


Author: tuexen
Date: Fri May 29 11:21:34 2015
New Revision: 283702
URL: https://svnweb.freebsd.org/changeset/base/283702

Log:
  MFC r275857:
  
  Initilize the msg_flags field consistently in all code paths.
  
  Reported by:	Coverity
  CID:		1018726

Modified:
  stable/10/lib/libc/net/sctp_sys_calls.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/lib/libc/net/sctp_sys_calls.c
==============================================================================
--- stable/10/lib/libc/net/sctp_sys_calls.c	Fri May 29 11:19:30 2015	(r283701)
+++ stable/10/lib/libc/net/sctp_sys_calls.c	Fri May 29 11:21:34 2015	(r283702)
@@ -597,6 +597,7 @@ sctp_sendmsg(int s,
 	msg.msg_iovlen = 1;
 	msg.msg_control = cmsgbuf;
 	msg.msg_controllen = CMSG_SPACE(sizeof(struct sctp_sndrcvinfo));
+	msg.msg_flags = 0;
 	cmsg = (struct cmsghdr *)cmsgbuf;
 	cmsg->cmsg_level = IPPROTO_SCTP;
 	cmsg->cmsg_type = SCTP_SNDRCV;
@@ -663,6 +664,7 @@ sctp_send(int sd, const void *data, size
 	msg.msg_iovlen = 1;
 	msg.msg_control = cmsgbuf;
 	msg.msg_controllen = CMSG_SPACE(sizeof(struct sctp_sndrcvinfo));
+	msg.msg_flags = 0;
 	cmsg = (struct cmsghdr *)cmsgbuf;
 	cmsg->cmsg_level = IPPROTO_SCTP;
 	cmsg->cmsg_type = SCTP_SNDRCV;
@@ -820,7 +822,6 @@ sctp_recvmsg(int s,
 		errno = EINVAL;
 		return (-1);
 	}
-	msg.msg_flags = 0;
 	iov.iov_base = dbuf;
 	iov.iov_len = len;
 	msg.msg_name = (caddr_t)from;
@@ -832,6 +833,7 @@ sctp_recvmsg(int s,
 	msg.msg_iovlen = 1;
 	msg.msg_control = cmsgbuf;
 	msg.msg_controllen = sizeof(cmsgbuf);
+	msg.msg_flags = 0;
 	sz = recvmsg(s, &msg, *msg_flags);
 	*msg_flags = msg.msg_flags;
 	if (sz <= 0) {
@@ -905,6 +907,7 @@ sctp_recvv(int sd,
 	msg.msg_iovlen = iovlen;
 	msg.msg_control = cmsgbuf;
 	msg.msg_controllen = sizeof(cmsgbuf);
+	msg.msg_flags = 0;
 	ret = recvmsg(sd, &msg, *flags);
 	*flags = msg.msg_flags;
 	if ((ret > 0) &&


More information about the svn-src-stable mailing list