svn commit: r292975 - stable/10/sys/dev/pci

NGie Cooper yaneurabeya at gmail.com
Thu Dec 31 20:38:54 UTC 2015


> On Dec 31, 2015, at 08:42, John Baldwin <john at baldwin.cx> wrote:
> 
> On Thursday, December 31, 2015 03:55:02 AM Garrett Cooper wrote:
>> Author: ngie
>> Date: Thu Dec 31 03:55:02 2015
>> New Revision: 292975
>> URL: https://svnweb.freebsd.org/changeset/base/292975
>> 
>> Log:
>>  MFC r278860:
>>  r278860 (by jmg):
>> 
>>  remove NULL check as M_WAITOK will not return NULL
>> 
>>  Reviewed by:	jhb
>>  Sponsored by:	FreeBSD Foundation
> 
> Including the metadata from the HEAD commit in the MFC can be misleading, and
> I think it is best ommitted.  For example, I did not review this MFC (and
> reviewing MFC's in their own right matters since they may require additional
> work than commits to HEAD due to ABI concerns), nor did the Foundation sponsor
> the MFC.  Rather, I think MFCs should only specify metadata related to the
> actual merge itself.

Agreed. I’ve changed my mfc_log script to skip over some more unnecessary svn log metadata: https://github.com/yaneurabeya/scratch/commit/4f897efb96f96f951ff3909857f67e63b24b733a .
Thanks :)!
-NGie


More information about the svn-src-stable mailing list