svn commit: r285967 - stable/10/sys/kern

Peter Wemm peter at wemm.org
Sun Aug 2 09:08:02 UTC 2015


On Tuesday, July 28, 2015 05:12:41 PM Konstantin Belousov wrote:
> Author: kib
> Date: Tue Jul 28 17:12:41 2015
> New Revision: 285967
> URL: https://svnweb.freebsd.org/changeset/base/285967
> 
> Log:
>   MFC r284956:
>   Do not calculate the stack's bottom address twice.

This is a bad MFC.  stack_addr is different for ia64 in 10.x and this breaks 
threading on ia64.    eg: ntpd crashes on startup in the cluster machines.


> Modified:
>   stable/10/sys/kern/kern_exec.c
> Directory Properties:
>   stable/10/   (props changed)
> 
> Modified: stable/10/sys/kern/kern_exec.c
> ============================================================================
> == --- stable/10/sys/kern/kern_exec.c	Tue Jul 28 17:08:32 2015	(r285966) +++
> stable/10/sys/kern/kern_exec.c	Tue Jul 28 17:12:41 2015	(r285967) @@
> -1116,7 +1116,7 @@ exec_new_vmspace(imgp, sv)
>  	 * process stack so we can check the stack rlimit.
>  	 */
>  	vmspace->vm_ssize = sgrowsiz >> PAGE_SHIFT;
> -	vmspace->vm_maxsaddr = (char *)sv->sv_usrstack - ssiz;
> +	vmspace->vm_maxsaddr = (char *)stack_addr;
> 
>  	return (0);
>  }
> _______________________________________________
> svn-src-all at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"

-- 
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com; KI6FJV
UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freebsd.org/pipermail/svn-src-stable/attachments/20150802/23a45144/attachment.bin>


More information about the svn-src-stable mailing list