svn commit: r267836 - stable/8/sys/dev/acpica

John Baldwin jhb at FreeBSD.org
Tue Jun 24 19:58:43 UTC 2014


Author: jhb
Date: Tue Jun 24 19:58:42 2014
New Revision: 267836
URL: http://svnweb.freebsd.org/changeset/base/267836

Log:
  MFC 253392:
  Workaround some broken BIOSes that specify edge-sensitive but active-low
  settings for ACPI-enumerated serial ports by forcing any IRQs that use
  an ISA IRQ value with these settings to active-high instead of active-low.
  
  This is known to occur with the BIOS on an Intel D2500CCE motherboard.

Modified:
  stable/8/sys/dev/acpica/acpi_resource.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/dev/   (props changed)
  stable/8/sys/dev/acpica/   (props changed)

Modified: stable/8/sys/dev/acpica/acpi_resource.c
==============================================================================
--- stable/8/sys/dev/acpica/acpi_resource.c	Tue Jun 24 19:58:18 2014	(r267835)
+++ stable/8/sys/dev/acpica/acpi_resource.c	Tue Jun 24 19:58:42 2014	(r267836)
@@ -134,6 +134,17 @@ acpi_config_intr(device_t dev, ACPI_RESO
     default:
 	panic("%s: bad resource type %u", __func__, res->Type);
     }
+
+#if defined(__amd64__) || defined(__i386__)
+    /*
+     * XXX: Certain BIOSes have buggy AML that specify an IRQ that is
+     * edge-sensitive and active-lo.  However, edge-sensitive IRQs
+     * should be active-hi.  Force IRQs with an ISA IRQ value to be
+     * active-hi instead.
+     */
+    if (irq < 16 && trig == ACPI_EDGE_SENSITIVE && pol == ACPI_ACTIVE_LOW)
+	pol = ACPI_ACTIVE_HIGH;
+#endif
     BUS_CONFIG_INTR(dev, irq, (trig == ACPI_EDGE_SENSITIVE) ?
 	INTR_TRIGGER_EDGE : INTR_TRIGGER_LEVEL, (pol == ACPI_ACTIVE_HIGH) ?
 	INTR_POLARITY_HIGH : INTR_POLARITY_LOW);


More information about the svn-src-stable-8 mailing list