svn commit: r219526 -
avg at freebsd.org
Fri Mar 11 23:08:13 UTC 2011
on 11/03/2011 21:50 Kostik Belousov said the following:
> On Fri, Mar 11, 2011 at 07:27:31PM +0000, Andriy Gapon wrote:
>> Author: avg
>> Date: Fri Mar 11 19:27:31 2011
>> New Revision: 219526
>> URL: http://svn.freebsd.org/changeset/base/219526
>> use even larger stack size for ZFS txg_sync_thread
>> While the stack size was larger than the default stack size on i386, it
>> was smaller than the default stack size on amd64 and apparently that
>> wasn't enough. So, bump the size to 4 pages. Upcoming ZFSv28 code uses
>> 8 pages for this stack size.
>> This is a direct commit to stable/8.
>> PR: kern/154681
>> Discussed with: pjd
>> Modified: stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c
>> --- stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c Fri Mar 11 19:21:42 2011 (r219525)
>> +++ stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c Fri Mar 11 19:27:31 2011 (r219526)
>> @@ -146,7 +146,7 @@ txg_sync_start(dsl_pool_t *dp)
>> * 32-bit x86. This is due in part to nested pools and
>> * scrub_visitbp() recursion.
>> - tx->tx_sync_thread = thread_create(NULL, 12<<10, txg_sync_thread,
>> + tx->tx_sync_thread = thread_create(NULL, 16<<10, txg_sync_thread,
>> dp, 0, &p0, TS_RUN, minclsyspri);
> What about architectures where PAGE_SIZE != 4096 ?
> We have ptoa() macro.
I agree, but this is not the moment when the style that you comment on was
introduced. So, it's better to review (and fix) the code in head.
More information about the svn-src-stable-8