svn commit: r218695 - stable/8/usr.bin/top

Sergey Kandaurov pluknet at freebsd.org
Wed Feb 16 08:36:30 UTC 2011


On 16 February 2011 09:54, Giorgos Keramidas <keramida at freebsd.org> wrote:
> On Wed, 16 Feb 2011 00:06:39 -0500, jhell <jhell at DataIX.net> wrote:
>> On Tue, 15 Feb 2011 01:33, keramida@ wrote:
>>> URL: http://svn.freebsd.org/changeset/base/218695
>>>
>>>  MFC 217746 from /head/usr.bin/top
>>>
>>>  Touch up the sample memory usage numbers a bit, to avoid wrapping
>>>  on terminal boundary.  While here add definition for 'G' and fix
>>>  the indentation of 'K' units.
> ..
>>> -.SH DESCRIPTION OF MEMORY
>>> -Mem: 9220K Active, 1032K Inact, 3284K Wired, 1M Cache, 2M Buf, 1320K Free
>>> +.SH DESCRIPTION OF MEMORY
>>> +Mem: 9220K Active, 1M Inact, 3284K Wired, 1M Cache, 2M Buf, 1320K Free
>>> Swap: 91M Total, 79M Free, 13% Inuse, 80K In, 104K Out
>>
>> Maybe being a little picky here but consistency in this might persuade
>> further questions on why Active is using K but yet Inact "being
>> smaller" than that is using M.
>>
>> Might be best to just take some active values straight from a running
>> top(1) output rather than blindly adjusting them.
>
> On Wed, 16 Feb 2011 08:50:30 +0300, Sergey Kandaurov <pluknet at freebsd.org> wrote:
>> Well, that was already broken before the change.
>
> It's still not too late to do that.  I'll replace the Mem: line with one
> from my current installation:
>
> Mem: 18M Active, 298M Inact, 119M Wired, 220K Cache, 110M Buf, 553M Free
>
> Does that look better?
>

>From my observations the line length (without trailing '/0') must be in [66,71]
range (both limits inclusive). Otherwise the line renders incorrectly for me.
Yours is one character longer.

-- 
wbr,
pluknet


More information about the svn-src-stable-8 mailing list