svn commit: r224858 - stable/8/sys/fs/nfsclient

Rick Macklem rmacklem at
Sun Aug 14 00:32:44 UTC 2011

Author: rmacklem
Date: Sun Aug 14 00:32:43 2011
New Revision: 224858

  MFC: r224532
  The new NFS client failed to vput() the new vnode if a setattr
  failed after the file was created in nfs_create(). This would
  probably only happen during a forced dismount. The old NFS client
  does have a vput() for this case. Detected by pho during recent
  testing, where an open syscall returned with a vnode still locked.

Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)

Modified: stable/8/sys/fs/nfsclient/nfs_clvnops.c
--- stable/8/sys/fs/nfsclient/nfs_clvnops.c	Sun Aug 14 00:20:37 2011	(r224857)
+++ stable/8/sys/fs/nfsclient/nfs_clvnops.c	Sun Aug 14 00:32:43 2011	(r224858)
@@ -1544,6 +1544,8 @@ again:
 			if (attrflag)
 				(void) nfscl_loadattrcache(&newvp, &nfsva, NULL,
 				    NULL, 0, 1);
+			if (error != 0)
+				vput(newvp);
 	if (!error) {

More information about the svn-src-stable-8 mailing list