svn commit: r205189 - stable/8/sys/dev/gem

Marius Strobl marius at FreeBSD.org
Mon Mar 15 19:13:37 UTC 2010


Author: marius
Date: Mon Mar 15 19:13:36 2010
New Revision: 205189
URL: http://svn.freebsd.org/changeset/base/205189

Log:
  MFC: r204222
  
  According to the Linux sungem driver, in case of Apple (K2) GMACs
  GEM_MIF_CONFIG_MDI0 cannot be trusted when the firmware has powered
  down the chip so the internal transceiver has to be hardcoded. This
  is also in line with the AppleGMACEthernet driver, which just doesn't
  distinguish between internal/external transceiver and MDIO/MDI1
  respectively in the first place. Tested by: Andreas Tobler

Modified:
  stable/8/sys/dev/gem/if_gem.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/xen/xenpci/   (props changed)

Modified: stable/8/sys/dev/gem/if_gem.c
==============================================================================
--- stable/8/sys/dev/gem/if_gem.c	Mon Mar 15 19:04:56 2010	(r205188)
+++ stable/8/sys/dev/gem/if_gem.c	Mon Mar 15 19:13:36 2010	(r205189)
@@ -297,8 +297,11 @@ gem_attach(struct gem_softc *sc)
 
 	/*
 	 * Fall back on an internal PHY if no external PHY was found.
+	 * Note that with Apple (K2) GMACs GEM_MIF_CONFIG_MDI0 can't be
+	 * trusted when the firmware has powered down the chip.
 	 */
-	if (error != 0 && (v & GEM_MIF_CONFIG_MDI0) != 0) {
+	if (error != 0 &&
+	    ((v & GEM_MIF_CONFIG_MDI0) != 0 || GEM_IS_APPLE(sc))) {
 		v &= ~GEM_MIF_CONFIG_PHY_SEL;
 		GEM_BANK1_WRITE_4(sc, GEM_MIF_CONFIG, v);
 		switch (sc->sc_variant) {


More information about the svn-src-stable-8 mailing list