SPOOFED: Re: svn commit: r209011 - stable/8/sys/dev/ath/ath_hal/ar5211

Rui Paulo rpaulo at freebsd.org
Fri Jun 11 08:23:24 UTC 2010

On 11 Jun 2010, at 02:46, Daniel O'Connor wrote:

> On 11/06/2010, at 6:04, Rui Paulo wrote:
>> Log:
>> MFC r208644:
>>  Due to the way HALDEBUG() is defined, we need to add curly brackets
>>  when using it as a sole if clause instruction.
>>  While there, fix 'const static' typo.
> Why not fix HALDEBUG? ie wrap it in do {  } while (0)
> Although that said when I looked at HALDEBUG on 8.0 it was defined as a function so it is a non issue there.
> HAL_DEBUG is different but I can't actually find where that is defined.

There's actually no problem in the code. This was to shut up a compiler warning on NetBSD. I probably should've said that in the commit log.

Rui Paulo

More information about the svn-src-stable-8 mailing list