svn commit: r249536 - stable/7

Dimitry Andric dim at
Tue Apr 16 06:53:21 UTC 2013

Author: dim
Date: Tue Apr 16 06:53:20 2013
New Revision: 249536

  MFC r249316:
  Ensure make -j N universe works correctly, by checking for an up-to-date
  make before starting the universe targets themselves.  Otherwise, all of
  the targets would attempt to build make simultaneously, overwriting each
  other's copies of the make object files and executable.  This could lead
  to strange errors, for example when partially-written make executables
  are invoked.
  Also amend r216620, to make the rest of universe wait properly until the
  upgrade_checks target is finished, by adding universe_${target}_prologue
  to the .ORDER target.  Otherwise, make will be too smart for its own
  good, and start building the universe targets simultaneously with the
  prologues anyway.

  stable/7/Makefile   (contents, props changed)

Modified: stable/7/Makefile
--- stable/7/Makefile	Tue Apr 16 06:52:32 2013	(r249535)
+++ stable/7/Makefile	Tue Apr 16 06:53:20 2013	(r249536)
@@ -274,7 +274,7 @@ make: .PHONY
 .if make(universe)
 TARGETS?=amd64 arm i386 ia64 pc98 powerpc sparc64
-universe: universe_prologue
+universe: universe_prologue upgrade_checks
 	@echo "--------------------------------------------------------------"
 	@echo ">>> make universe started on ${STARTTIME}"
@@ -285,7 +285,7 @@ KERNCONFS!=	cd ${.CURDIR}/sys/${target}/
 		! -name DEFAULTS ! -name LINT
 universe: universe_${target}
-.ORDER: universe_prologue universe_${target} universe_epilogue
+.ORDER: universe_prologue upgrade_checks universe_${target}_prologue universe_${target} universe_epilogue
 .if !defined(MAKE_JUST_KERNELS)
 	@echo ">> ${target} started on `LC_ALL=C date`"

More information about the svn-src-stable-7 mailing list