svn commit: r192033 - stable/7/sys/dev/ata

[Bruce Simpson]

John Baldwin wrote:
> http://www.FreeBSD.org/~jhb/patches/ata_ali.patch
> Ok, I've uploaded the patch, I must have just sent it inline before.
>   

Thanks!

I did a p4 integ on my p4 work branch, built a NanoBSD USB stick image 
with this patch incorporated into the kernel, booted from it 
successfully on the affected machine, and got this panic just after the 
WITNESS warning.

Had to transcribe by hand, no debugging symbols at the moment.

Fatal trap 12: page fault while in kernel mode
cpuid = 0 apic id = 00
fault virtual address = 0x0
fault code = supervisor read, page not present
instruction pointer = 0x20:0x0
stack pointer = 0x28:0xc4adbb68
frame pointer = 0x28:0xc4adbb9c
code segment = base 0x0, limit 0xfffff, type 0x1b
processor eflags = interrupt enabled, resume, IOPL = 0
current process = 4 (g_down)
[thread pid 4 tid 100008]
Stopped at 0: error reading from address 0

ata_begin_transaction+0x18a
ata_start+0x1db
ata_queue_request+0x4a0
ad_strategy+0x28f
g_disk_start+0x16a
g_io_schedule_down+0x281
g_down_procbody+0x8d
fork_exit+0xb8
fork_trampoline+0x8

Looks like some sort of switch table, call %*edx, just after 
ata_pio_write() in that function. I'll try to grab line number info on 
next boot from NanoBSD build tree.

Don't have any other HEAD stuff compiled but that does sound fairly far 
down in the body of ata_begin_transaction() and it looks like it's 
inside one of the switch cases.


>
> The same patch will apply to 7-stable though it will have to be applied 
> to ata-chipset.c instead.
>   

I'll try applying this there next, just in case this is an 8.x specific 
problem.

thanks!
BMS