svn commit: r341951 - stable/12/sys/dev/mlx5/mlx5_ib

Hans Petter Selasky hselasky at FreeBSD.org
Wed Dec 12 12:33:13 UTC 2018


Author: hselasky
Date: Wed Dec 12 12:33:12 2018
New Revision: 341951
URL: https://svnweb.freebsd.org/changeset/base/341951

Log:
  MFC r341569:
  mlx5ib: Fix null pointer dereference in mlx5_ib_create_srq
  
  Although "create_srq_user" does overwrite "in.pas" on some paths, it
  also contains at least one feasible path which does not overwrite it.
  
  Sponsored by:   Mellanox Technologies

Modified:
  stable/12/sys/dev/mlx5/mlx5_ib/mlx5_ib_srq.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/mlx5/mlx5_ib/mlx5_ib_srq.c
==============================================================================
--- stable/12/sys/dev/mlx5/mlx5_ib/mlx5_ib_srq.c	Wed Dec 12 12:32:14 2018	(r341950)
+++ stable/12/sys/dev/mlx5/mlx5_ib/mlx5_ib_srq.c	Wed Dec 12 12:33:12 2018	(r341951)
@@ -287,7 +287,7 @@ struct ib_srq *mlx5_ib_create_srq(struct ib_pd *pd,
 	else
 		err = create_srq_kernel(dev, srq, &in, buf_size);
 
-	if (err) {
+	if (err || !in.pas) {
 		mlx5_ib_warn(dev, "create srq %s failed, err %d\n",
 			     pd->uobject ? "user" : "kernel", err);
 		goto err_srq;


More information about the svn-src-stable-12 mailing list