svn commit: r310883 - stable/11/sys/dev/etherswitch

Konstantin Belousov kostikbel at gmail.com
Sat Dec 31 09:24:23 UTC 2016


On Sat, Dec 31, 2016 at 01:58:05AM +0000, Luiz Otavio O Souza wrote:
> -static int
>  etherswitchioctl(struct cdev *cdev, u_long cmd, caddr_t data, int flags, struct thread *td)
>  {
>  	struct etherswitch_softc *sc = cdev->si_drv1;
Since si_drv1 is dereferenced in the cdevsw methods, please consider
converting the driver to use make_dev_s(9) KPI.  This would fix a race
with a thread accessing not yet initialized si_drv1 in parallel with
the makedev thread.


More information about the svn-src-stable-11 mailing list