svn commit: r316140 - stable/10/sys/dev/xen/netfront

Roger Pau Monné royger at FreeBSD.org
Thu Mar 30 08:36:42 UTC 2017


On Wed, Mar 29, 2017 at 10:12:23AM -0700, Ngie Cooper (yaneurabeya) wrote:
> 
> > On Mar 29, 2017, at 08:34, Roger Pau Monné <royger at FreeBSD.org> wrote:
> > 
> > Author: royger
> > Date: Wed Mar 29 15:34:52 2017
> > New Revision: 316140
> > URL: https://svnweb.freebsd.org/changeset/base/316140
> > 
> > Log:
> >  xen/netfront: release resources on removal
> > 
> >  Current netfront code doesn't release the resources (grants and mbufs) on
> >  removal. Add a new helper that releases the resources, so FreeBSD doesn't run
> >  out of grants or memory when performing heavy hotplug/unplug of Xen PV nic
> >  devices.
> > 
> >  This is a direct commit to stable/10 because the code in newer branches has
> >  been completely refactored and no longer has this issue.
> > 
> >  Reviewed by:		royger
> >  Submitted by:		Ouyangzhaowei <ouyangzhaowei at huawei.com>
> >  Differential review:	https://reviews.freebsd.org/D10088
> 
> Hi Roger,
> 	This broke GENERIC/i386 with a -Wformat warning, but was fixed in r316170.

Sight. It was supposedly "thoroughly tested". Sorry for the breakage and thanks
for the fix!

Roger.


More information about the svn-src-stable-10 mailing list