svn commit: r287388 - stable/10/sys/dev/sound/midi

Tai-hwa Liang avatar at FreeBSD.org
Tue Sep 1 22:35:54 UTC 2015


Author: avatar
Date: Tue Sep  1 22:35:53 2015
New Revision: 287388
URL: https://svnweb.freebsd.org/changeset/base/287388

Log:
  MFC r286887: Using the error return code documented in the comment.
  
  Though there is no direct midi_uninit() caller amongst existing drivers
  at this moment, a quick experiment indicates that EBUSY gives users more
  precise error message once drivers start to honour this result.  For example,
  emu_midi_detach() should check the result of mpu401_uninit() and block
  module unloading if there is any MIDI I/O in progress.

Modified:
  stable/10/sys/dev/sound/midi/midi.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/sound/midi/midi.c
==============================================================================
--- stable/10/sys/dev/sound/midi/midi.c	Tue Sep  1 22:28:23 2015	(r287387)
+++ stable/10/sys/dev/sound/midi/midi.c	Tue Sep  1 22:35:53 2015	(r287388)
@@ -403,7 +403,7 @@ midi_uninit(struct snd_midi *m)
 {
 	int err;
 
-	err = ENXIO;
+	err = EBUSY;
 	mtx_lock(&midistat_lock);
 	mtx_lock(&m->lock);
 	if (m->busy) {


More information about the svn-src-stable-10 mailing list