svn commit: r269061 - stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Alexander Motin mav at FreeBSD.org
Thu Jul 24 14:55:46 UTC 2014


Author: mav
Date: Thu Jul 24 14:55:45 2014
New Revision: 269061
URL: http://svnweb.freebsd.org/changeset/base/269061

Log:
  MFC r268420:
  Remove IO_SYNC flag when writing extended file attributes on ZFS.
  
  While it is possible to create and write file, modify its permissions, etc.
  without ever doing sync, it looks odd that it is required for setting
  extended file attributes on ZFS.  UFS does not do sync there too.
  
  Samba uses those extended attributes to store some its data, and doing it
  synchronously by many times reduces file creation performance for systems
  without SLOG device.

Modified:
  stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
==============================================================================
--- stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c	Thu Jul 24 14:24:27 2014	(r269060)
+++ stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c	Thu Jul 24 14:55:45 2014	(r269061)
@@ -6855,7 +6855,7 @@ vop_setextattr {
 	va.va_size = 0;
 	error = VOP_SETATTR(vp, &va, ap->a_cred);
 	if (error == 0)
-		VOP_WRITE(vp, ap->a_uio, IO_UNIT | IO_SYNC, ap->a_cred);
+		VOP_WRITE(vp, ap->a_uio, IO_UNIT, ap->a_cred);
 
 	VOP_UNLOCK(vp, 0);
 	vn_close(vp, flags, ap->a_cred, td);


More information about the svn-src-stable-10 mailing list