svn commit: r347547 - in projects/fuse2: . share/man/man5 sys/fs/fuse

[Alan Somers]

Author: asomers
Date: Mon May 13 19:47:31 2019
New Revision: 347547
URL: https://svnweb.freebsd.org/changeset/base/347547

Log:
  fusefs: remove the vfs.fusefs.sync_resize syctl
  
  This sysctl was added > 6.5 years ago for no clear purpose.  I'm guessing
  that it may have had something to do with the incomplete attribute cache.
  But the attribute cache works now.  Since there's no clear motivation for
  this sysctl, it's best to remove it.
  
  Sponsored by:	The FreeBSD Foundation

Modified:
  projects/fuse2/UPDATING
  projects/fuse2/share/man/man5/fusefs.5
  projects/fuse2/sys/fs/fuse/fuse_io.c
  projects/fuse2/sys/fs/fuse/fuse_ipc.h
  projects/fuse2/sys/fs/fuse/fuse_node.c

Modified: projects/fuse2/UPDATING
==============================================================================
--- projects/fuse2/UPDATING	Mon May 13 19:35:35 2019	(r347546)
+++ projects/fuse2/UPDATING	Mon May 13 19:47:31 2019	(r347547)
@@ -37,9 +37,9 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 13.x IS SLOW:
 	been removed from mount_fusefs(8).  You can safely remove them from
 	your scripts, because they had no effect.
 
-	The vfs.fusefs.fix_broken_io sysctl has been removed.  If you felt the
-	need to set it to a non-default value, please tell asomers at FreeBSD.org
-	why.
+	The vfs.fusefs.fix_broken_io and vfs.fusefs.sync_resize sysctls have
+	been removed.  If you felt the need to set either to a non-default
+	value, please tell asomers at FreeBSD.org why.
 
 20190507:
 	The IPSEC option has been removed from GENERIC.  Users requiring

Modified: projects/fuse2/share/man/man5/fusefs.5
==============================================================================
--- projects/fuse2/share/man/man5/fusefs.5	Mon May 13 19:35:35 2019	(r347546)
+++ projects/fuse2/share/man/man5/fusefs.5	Mon May 13 19:47:31 2019	(r347547)
@@ -105,7 +105,6 @@ misbehaving.
 .\" vfs.fusefs.iov_credit: I don't understand it well enough
 .\" vfs.fusefs.iov_permanent_bufsize: I don't understand it well enough
 .\" vfs.fusefs.fix_broken_io: I don't understand it well enough
-.\" vfs.fusefs.sync_resize: useless and should be removed
 .\" vfs.fusefs.refresh_size: probably useless?
 .\" vfs.fusefs.mmap_enable: why is this optional?
 .\" vfs.fusefs.data_cache_invalidate: what is this needed for?

Modified: projects/fuse2/sys/fs/fuse/fuse_io.c
==============================================================================
--- projects/fuse2/sys/fs/fuse/fuse_io.c	Mon May 13 19:35:35 2019	(r347546)
+++ projects/fuse2/sys/fs/fuse/fuse_io.c	Mon May 13 19:47:31 2019	(r347547)
@@ -709,7 +709,7 @@ again:
 			break;
 	} while (uio->uio_resid > 0 && n > 0);
 
-	if (fuse_sync_resize && (fvdat->flag & FN_SIZECHANGE) != 0)
+	if ((fvdat->flag & FN_SIZECHANGE) != 0)
 		fuse_vnode_savesize(vp, cred, pid);
 
 	return (err);

Modified: projects/fuse2/sys/fs/fuse/fuse_ipc.h
==============================================================================
--- projects/fuse2/sys/fs/fuse/fuse_ipc.h	Mon May 13 19:35:35 2019	(r347546)
+++ projects/fuse2/sys/fs/fuse/fuse_ipc.h	Mon May 13 19:47:31 2019	(r347547)
@@ -231,7 +231,6 @@ enum fuse_data_cache_mode {
 extern int fuse_data_cache_mode;
 extern int fuse_data_cache_invalidate;
 extern int fuse_mmap_enable;
-extern int fuse_sync_resize;
 
 static inline struct fuse_data *
 fuse_get_mpdata(struct mount *mp)

Modified: projects/fuse2/sys/fs/fuse/fuse_node.c
==============================================================================
--- projects/fuse2/sys/fs/fuse/fuse_node.c	Mon May 13 19:35:35 2019	(r347546)
+++ projects/fuse2/sys/fs/fuse/fuse_node.c	Mon May 13 19:47:31 2019	(r347547)
@@ -135,13 +135,6 @@ SYSCTL_INT(_vfs_fusefs, OID_AUTO, refresh_size, CTLFLA
     "If non-zero, and no dirty file extension data is buffered, fetch file "
     "size before write operations");
 
-int	fuse_sync_resize = 1;
-
-SYSCTL_INT(_vfs_fusefs, OID_AUTO, sync_resize, CTLFLAG_RW,
-    &fuse_sync_resize, 0,
-    "If a cached write extended a file, inform FUSE filesystem of the changed"
-    "size immediately subsequent to the issued writes");
-
 static int
 sysctl_fuse_cache_mode(SYSCTL_HANDLER_ARGS)
 {