svn commit: r346091 - projects/hps_callouts/sys/net

[Hans Petter Selasky]

Author: hselasky
Date: Wed Apr 10 18:12:31 2019
New Revision: 346091
URL: https://svnweb.freebsd.org/changeset/base/346091

Log:
  Callout drain does not have to be followed by a callout stop call.
  Fix bogus code.
  
  Sponsored by:	Mellanox Technologies

Modified:
  projects/hps_callouts/sys/net/if_spppsubr.c

Modified: projects/hps_callouts/sys/net/if_spppsubr.c
==============================================================================
--- projects/hps_callouts/sys/net/if_spppsubr.c	Wed Apr 10 17:56:44 2019	(r346090)
+++ projects/hps_callouts/sys/net/if_spppsubr.c	Wed Apr 10 18:12:31 2019	(r346091)
@@ -1060,15 +1060,13 @@ sppp_detach(struct ifnet *ifp)
 	KASSERT(mtx_initialized(&sp->mtx), ("sppp mutex is not initialized"));
 
 	/* Stop keepalive handler. */
- 	if (!callout_drain(&sp->keepalive_callout))
-		callout_stop(&sp->keepalive_callout);
+ 	callout_drain(&sp->keepalive_callout);
 
 	for (i = 0; i < IDX_COUNT; i++) {
-		if (!callout_drain(&sp->ch[i]))
-			callout_stop(&sp->ch[i]);
+		callout_drain(&sp->ch[i]);
 	}
-	if (!callout_drain(&sp->pap_my_to_ch))
-		callout_stop(&sp->pap_my_to_ch);
+	callout_drain(&sp->pap_my_to_ch);
+
 	mtx_destroy(&sp->pp_cpq.ifq_mtx);
 	mtx_destroy(&sp->pp_fastq.ifq_mtx);
 	mtx_destroy(&sp->mtx);