svn commit: r336014 - projects/pnfs-planb-server/sys/fs/nfsserver
Rick Macklem
rmacklem at FreeBSD.org
Thu Jul 5 20:12:35 UTC 2018
Author: rmacklem
Date: Thu Jul 5 20:12:34 2018
New Revision: 336014
URL: https://svnweb.freebsd.org/changeset/base/336014
Log:
Change the pNFS server so that it does not disable a mirrored DS when a
client does a LayoutReturn with an error report of NFSERR_STALE from a DS.
The current FreeBSD client can generate these errors for an operational
DS while doing a recovery of a mirror after a mirrored DS has been repaired.
I am not sure why these errors occur, but my best current guess is a race between
the Layout Recall issued by the kernel code run from pnfsdscopymr(8) and a
Read operation on the DS for the file bing copied.
The errrors are not fatal, since the client falls back on doing I/O through
the MDS, which can do the I/O successfully as a proxy. (The fact that the
MDS can do this indicates that the file does still exist on the functioning
DS.)
Modified:
projects/pnfs-planb-server/sys/fs/nfsserver/nfs_nfsdstate.c
Modified: projects/pnfs-planb-server/sys/fs/nfsserver/nfs_nfsdstate.c
==============================================================================
--- projects/pnfs-planb-server/sys/fs/nfsserver/nfs_nfsdstate.c Thu Jul 5 18:55:42 2018 (r336013)
+++ projects/pnfs-planb-server/sys/fs/nfsserver/nfs_nfsdstate.c Thu Jul 5 20:12:34 2018 (r336014)
@@ -6750,9 +6750,10 @@ nfsrv_flexlayouterr(struct nfsrv_descript *nd, uint32_
NFSD_DEBUG(4, "flexlayouterr op=%d stat=%d\n", opnum,
stat);
/*
- * Except for NFSERR_ACCES errors, disable the mirror.
+ * Except for NFSERR_ACCES and NFSERR_STALE errors,
+ * disable the mirror.
*/
- if (stat != NFSERR_ACCES)
+ if (stat != NFSERR_ACCES && stat != NFSERR_STALE)
nfsrv_delds(devid, p);
}
}
More information about the svn-src-projects
mailing list