svn commit: r304868 - projects/clang390-import/lib/clang

[Bryan Drewery]

On 8/26/2016 5:58 PM, Ngie Cooper wrote:
> On Fri, Aug 26, 2016 at 4:39 PM, Dimitry Andric <dim at freebsd.org> wrote:
> ...
>> I used ${SRCTOP} and ${OBJTOP} initially, until I realized that the
>> latter didn't work for builds which are started during bootstrap-tools.
>> So I locally reverted all these changes before committing this WIP.
>>
>> That said, ${SRCTOP} makes it look a little nicer, but there are lots
>> of other instances of using ../../.. in these Makefiles.  It does not
>> really bother me. :)
> 
> Can you use something like this instead to signal the "right intent",
> and someday hopefully this will just work (tm) with a bit more effort?
> Thanks,
> -Ngie
> 
> # XXX: SRCTOP isn't available until Y stage in the build
> SRCTOP?= ${.CURDIR:H:H}
> LLVM_SRCS= ${SRCTOP}/contrib/llvm
> 

SRCTOP should work just fine here.  He did note that 'the latter'
(OBJTOP) wouldn't work, since the early build likely is getting a normal
build OBJTOP/tmp value for OBJTOP since it builds with
MAKEOBJDIRPREFIX=${WORLDTMP}

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-projects/attachments/20160826/1c1b3c40/attachment.sig>