svn commit: r298701 - in projects/zfsd/head: cddl/sbin/zfsd share/mk

[Warner Losh]

On Wed, Apr 27, 2016 at 12:26 PM, Baptiste Daroussin <bapt at freebsd.org>
wrote:

> On Wed, Apr 27, 2016 at 10:20:19AM -0600, Alan Somers wrote:
> > On Wed, Apr 27, 2016 at 10:13 AM, Baptiste Daroussin <bapt at freebsd.org>
> > wrote:
> >
> > > On Wed, Apr 27, 2016 at 03:27:23PM +0000, Alan Somers wrote:
> > > > Author: asomers
> > > > Date: Wed Apr 27 15:27:23 2016
> > > > New Revision: 298701
> > > > URL: https://svnweb.freebsd.org/changeset/base/298701
> > > >
> > > > Log:
> > > >   Replace LDADD with LIBADD and NO_MAN with MK_MAN
> > > >
> > > >   Sponsored by:       Spectra Logic Corp
> > > >
> > > > Modified:
> > > >   projects/zfsd/head/cddl/sbin/zfsd/Makefile.common
> > > >   projects/zfsd/head/share/mk/src.libnames.mk
> > > >
> > > > Modified: projects/zfsd/head/cddl/sbin/zfsd/Makefile.common
> > > >
> > >
> ==============================================================================
> > > > --- projects/zfsd/head/cddl/sbin/zfsd/Makefile.common Wed Apr 27
> > > 15:25:18 2016        (r298700)
> > > > +++ projects/zfsd/head/cddl/sbin/zfsd/Makefile.common Wed Apr 27
> > > 15:27:23 2016        (r298701)
> > > > @@ -10,7 +10,7 @@ SRCS=               callout.cc              \
> > > >               zpool_list.cc           \
> > > >               zfsd_main.cc
> > > >
> > > > -NO_MAN=              YES
> > > > +MK_MAN=              no
> > >
> > > This is supposed to be:
> > > MAN=
> > >
> > > with no value assigned and not MK_MAN
> > >
> > > Best regards,
> > > Bapt
> > >
> >
> > Ok, I'll change it.  Is that a recent change?  When it was still NO_MAN,
> > make printed an error advising me to use "MK_MAN=no".
>
> I do not remember when this change happened but iirc it was long ago (I do
> not
> also remember about the advice).
>
> All I know is there are 334 MAN= and only 3 MK_MAN=no. Others might know
> better
> (Warner?)
>

There should be zero MK_MAN=no. That's always an error to set in a Makefile
in the tree (though we set it for some phaes in Makefile.inc1 during
buildworld). We transitioned from NO_MAN=yes to MAN= when we reworked where
the man pages were installed. This was in r74806 when ru@ changed the list
of man pages. If MAN was empty no man pages are installed. This was only 15
years ago...

The reason for the change was that you can't easily change a default so we
eliminated all the NO options that were user visible into MK options. But
MK options are supposed to only be set by WITHOUT_ and WITH_ options and
never directly by Makefile or by user action (though we've relaxed it a bit
for buildworld things in Makefile.inc1).

Warner