svn commit: r277543 - projects/ifnet/sys/net

[John-Mark Gurney]

Garrett Cooper wrote this message on Thu, Jan 22, 2015 at 16:18 -0800:
> On Jan 22, 2015, at 16:02, Gleb Smirnoff <glebius at FreeBSD.org> wrote:
> 
> > Author: glebius
> > Date: Fri Jan 23 00:02:26 2015
> > New Revision: 277543
> > URL: https://svnweb.freebsd.org/changeset/base/277543
> > 
> > Log:
> >  Return EOPNOTSUPP in case of not supported option.
> > 
> > Modified:
> >  projects/ifnet/sys/net/if_ethersubr.c
> > 
> > Modified: projects/ifnet/sys/net/if_ethersubr.c
> > ==============================================================================
> > --- projects/ifnet/sys/net/if_ethersubr.c	Thu Jan 22 23:59:35 2015	(r277542)
> > +++ projects/ifnet/sys/net/if_ethersubr.c	Fri Jan 23 00:02:26 2015	(r277543)
> > @@ -985,7 +985,7 @@ ether_ioctl(struct ifnet *ifp, u_long co
> > 		}
> > 		break;
> > 	default:
> > -		error = EINVAL;			/* XXX netbsd has ENOTTY??? */
> > +		error = EOPNOTSUPP;
> > 		break;
> > 	}
> > 	return (error);
> 
> Uh, didn?t you just break the ioctl(2) ERRORS guarantee?

[...]

>      [ENOTTY]           The specified request does not apply to the kind of
>                         object that the descriptor fd references.

[...]

Yeh, I think ENOTTY should have been returned instead...


-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."