svn commit: r286484 - projects/collation/usr.bin/localedef

[Bruce Evans]

On Thu, 13 Aug 2015, Baptiste Daroussin wrote:

> On Thu, Aug 13, 2015 at 12:16:41PM +1000, Bruce Evans wrote:
>> On Wed, 12 Aug 2015, Bruce Simpson wrote:
>>>>> ...
>>>>> Can you commit this one to HEAD && move it to the right header?
>>
>> This has too many bugs to commit.
>
> FYI the version proposed for tree(3):
>
> #define RB_COUNT(x, name, head, cnt) do {	\
> 	(cnt) = 0;				\
> 	RB_FOREACH((x), name, (head)) {		\
> 		(cnt)++;			\
> 	}					\
> } while (0)

Now it is bug for bug consistent with tree.h in using a space instead of
a tab after #define (tree.h is inconsistent with itself for only 5 out
of 82 #define's).

It doesn't line up the backslashe the same.  tree.h consistently lines
them up in column 72 whenever possible.

It adds 1 more inconsistency for the do-while(0) hack.  tree.h uses
/*CONSTCOND*/ lint markup for 10 of 11 instances.  This is too ugly
for me, but it is the existing style.

Bruce