svn commit: r274428 - projects/arm64/sys/arm64/include

Tijl Coosemans tijl at FreeBSD.org
Thu Nov 13 08:39:39 UTC 2014


On Thu, 13 Nov 2014 11:37:15 +1100 (EST) Bruce Evans <brde at optusnet.com.au> wrote:
> On Wed, 12 Nov 2014, Andrew Turner wrote:
> 
> > Log:
> >  Fix the values for __WCHAR_{MIN,MAX}
> >
> > Modified:
> >  projects/arm64/sys/arm64/include/_types.h
> >
> > Modified: projects/arm64/sys/arm64/include/_types.h
> > ==============================================================================
> > --- projects/arm64/sys/arm64/include/_types.h	Wed Nov 12 12:46:57 2014	(r274427)
> > +++ projects/arm64/sys/arm64/include/_types.h	Wed Nov 12 13:19:18 2014	(r274428)
> > @@ -94,8 +94,8 @@ typedef	__uint64_t	__vm_pindex_t;
> > typedef	__uint64_t	__vm_size_t;
> > typedef	unsigned int	___wchar_t;
> >
> > -#define	__WCHAR_MIN	__INT_MIN	/* min value for a wchar_t */
> > -#define	__WCHAR_MAX	__INT_MAX	/* max value for a wchar_t */
> > +#define	__WCHAR_MIN	__UINT_MIN	/* min value for a wchar_t */
> > +#define	__WCHAR_MAX	__UINT_MAX	/* max value for a wchar_t */
> >
> > /*
> >  * Unusual type definitions.
> 
> This looks bad.
> 
> 3 underscores for ___wchar_t is execessive.  All arches have this bug.  It
> is not even needed to give an extra level of obfuscation below __wchar_t,
> since the usual spelling __wchar_t is never used.

__wchar_t is used by clang with -fms-extensions.


More information about the svn-src-projects mailing list