svn commit: r265045 - projects/random_number_generator/sys/dev/random

John Baldwin jhb at freebsd.org
Mon Apr 28 14:45:26 UTC 2014


On Monday, April 28, 2014 07:51:08 AM Mark Murray wrote:
> Author: markm
> Date: Mon Apr 28 07:51:07 2014
> New Revision: 265045
> URL: http://svnweb.freebsd.org/changeset/base/265045
> 
> Log:
>   It turns out powerpc also doesn't have __uint128_t.
> 
> Modified:
>   projects/random_number_generator/sys/dev/random/uint128.h
> 
> Modified: projects/random_number_generator/sys/dev/random/uint128.h
> ============================================================================
> == --- projects/random_number_generator/sys/dev/random/uint128.h	Mon Apr 28
> 07:50:45 2014	(r265044) +++
> projects/random_number_generator/sys/dev/random/uint128.h	Mon Apr 28
> 07:51:07 2014	(r265045) @@ -34,7 +34,7 @@
>   * Everyone knows you always need the __uint128_t types!
>   */
> 
> -#if !defined(__arm__) && !defined(__mips__) && !defined(__i386__) &&
> !defined(__pc98__) +#if !defined(__arm__) && !defined(__mips__) &&
> !defined(__i386__) && !defined(__pc98__) && !defined(__powerpc__) /* We do
> have an inbuilt __uint128_t type */

A better test would be to use

#ifdef __SIZEOF_INT128__

instead of listing architectures.  (Especially given it might be true on
a given platform based on compiler options like -march.)  This is what
Boost uses to detect a native 128-bit integer and works with both GCC and
clang.

-- 
John Baldwin


More information about the svn-src-projects mailing list