svn commit: r238907 - projects/calloutng/sys/kern

John Baldwin jhb at freebsd.org
Thu Sep 13 14:27:56 UTC 2012


On Wednesday, September 12, 2012 8:07:11 pm Attilio Rao wrote:
> On Wed, Sep 12, 2012 at 8:11 PM, John Baldwin <jhb at freebsd.org> wrote:
> > On Monday, September 10, 2012 9:11:22 pm Attilio Rao wrote:
> >> Speaking of which, I think it is time for curthread != NULL checks in
> >> the locking primitives to go, or there is a good reason I really don't
> >> understand to keep them?
> >
> > They can probably be axed.
> 
> What do you think about this?
> Please note that I would also axe the check in printtrap() on several
> arches, but maybe there is a valid reason to keep it I'm not thinking
> right now, so I left it out in this patch.

There can be a window where curthread is NULL during early boot (e.g. if
you got a trap / fault during initi386() or the equivalent).

I think the patch is fine.

-- 
John Baldwin


More information about the svn-src-projects mailing list