svn commit: r241744 - projects/bhyve/usr.sbin/bhyve

[Peter Grehan]

On 10/23/12 3:55 AM, Jilles Tjoelker wrote:
> On Mon, Oct 22, 2012 at 05:18:11PM -0600, Peter Grehan wrote:
>>> Case 4 looks wrong. A 32-bit write clears the top 32 bits of the
>>> register instead of preserving them.
>
>>    Yep, you're right. How about:
>
>>   >  +	case 4:
>>   >  +		val = (reg & ~0xffffffffUL) | (operand & 0xffffffffUL);
>>   >  +		break;
>
> I think you mean:
> 	val = operand &  0xffffffffUL;
>
> Right?

  Don't think so - the high 32 bits of the target register need to be 
or'd in, as you originally mentioned.

later,

Peter.