svn commit: r241744 - projects/bhyve/usr.sbin/bhyve

Peter Grehan grehan at freebsd.org
Mon Oct 22 23:18:25 UTC 2012


> Case 4 looks wrong. A 32-bit write clears the top 32 bits of the
> register instead of preserving them.

  Yep, you're right. How about:

 > +	case 4:
 > +		val = (reg & ~0xffffffffUL) | (operand & 0xffffffffUL);
 > +		break;

> I have no idea whether this will actually fix/break anything.

  Lucky so far but it would be sure to blow up in the future.

later,

Peter.



More information about the svn-src-projects mailing list