svn commit: r241153 - in projects/bhyve/sys/boot: common userboot/userboot

Peter Grehan grehan at freebsd.org
Wed Oct 3 23:24:47 UTC 2012


Hi Peter,

> IMHO, the comment here is somewhat confusing

  Agreed.

> Can I suggest an alternate comment along the lines of:
> /*
>   * (Maximum?) Dictionary size in cells.  Note that the default FICL dictionary
>   * requires ~4000 cells.
>   */

  The irony is that FICL_DEFAULT_DICT, used if the passed in param to 
ficlInitSystem() is <=0, is actually 12288 on all arches.

  How about if I just remove the '~4000 cells' text, and maybe put in 
something like

  * FreeBSD loader default dictionary cells

  The irony is that FICL_DEFAULT_DICT, used if the passed in param to 
ficlInitSystem() is <=0, is actually 12288 on all arches.

later,

Peter.



More information about the svn-src-projects mailing list