svn commit: r233072 - projects/nand/sys/kern

[Konstantin Belousov]

On Sat, Mar 17, 2012 at 09:51:16AM +0100, Pawel Jakub Dawidek wrote:
> On Sat, Mar 17, 2012 at 03:18:29AM +0000, Grzegorz Bernacki wrote:
> > Author: gber
> > Date: Sat Mar 17 03:18:28 2012
> > New Revision: 233072
> > URL: http://svn.freebsd.org/changeset/base/233072
> > 
> > Log:
> >   Add VFS changes necessary for NANDFS to work.
> >   
> >   Ignore B_MANAGED buffer by syncer and ignore signal when msleep as it
> >   can cause file system inconsistency.
> 
> I'd suggest running these changes through kib at . Especially vn_start_write()
> change below looks ugly, but maybe it is only temporary?
It is not only ugly (and  object against it).

If the change makes any difference for the filesystem, then I just argue
that the filesystem is broken. The vn_start_write() is done on the
VFS entry peripheral, long before filesystem code is hit.

I did not looked at the managed changes, you would need to describe 
what is wrong with current code and what is the purpose of the changes.
B_MANAGED came from xfs, it seems, or at least xfs is the only current
consumer of B_MANAGED buffers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-projects/attachments/20120317/83f6f650/attachment.pgp