svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph...

[Michael Tuexen]

> On 2. Sep 2020, at 20:28, Pedro Giffuni <pfg at FreeBSD.org> wrote:
> 
> 
> On 02/09/2020 13:06, Alexey Dokuchaev wrote:
>> On Wed, Sep 02, 2020 at 10:18:15AM -0500, Pedro Giffuni wrote:
>>> On 01/09/2020 21:05, Alexey Dokuchaev wrote:
>>>> ...
>>>> This is common sense.  I can't count how often I wanted to hack on
>>>> something in the base/kernel and was turned away by this atrocious
>>>> excessive whitespace mess.
>>>> 
>>>> Thank you Mateusz for cleaning this up.
>>> I honestly don't care much, but spaces do no harm and can make the code
>>> more readable. Sort of a silent comment, or what you do in written
>>> language when you start a new paragraph.
>> Right, but that's the example of appropriate usage of whitespace.  I was
>> talking about *excessive* whitespace, that is, more than two \n's in a row
>> if we speak of newlines (subject of these commits).
> 
> But how much space is rather subjective so Michael is right in asking what rule has been violated.
> 
> No one is asking for the change to be reverted: the damage, if any, is already done.
Just to be clear: I have NOT asked for reverting, I did not mentioned it.

I want to understand which rules have to be followed (and why).
The why was explained: Some developers don't work on files which violate
whitespace rules.

I just want to know the rules. Without knowing them, I can't follow them...

Best regards
Michael
> 
> Pedro.
> 
> 
>> ./danfe

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5257 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20200902/c26c8a0a/attachment.bin>