svn commit: r367147 - head/sys/netinet

John Baldwin jhb at FreeBSD.org
Thu Oct 29 22:17:00 UTC 2020


Author: jhb
Date: Thu Oct 29 22:16:59 2020
New Revision: 367147
URL: https://svnweb.freebsd.org/changeset/base/367147

Log:
  Remove an extra if_ref().
  
  In r348254, if_snd_tag_alloc() routines were changed to bump the ifp
  refcount via m_snd_tag_init().  This function wasn't in the tree at
  the time and wasn't updated for the new semantics, so was still doing
  a separate bump after if_snd_tag_alloc() returned.
  
  Reviewed by:	gallatin
  Sponsored by:	Netflix
  Differential Revision:	https://reviews.freebsd.org/D26999

Modified:
  head/sys/netinet/tcp_ratelimit.c

Modified: head/sys/netinet/tcp_ratelimit.c
==============================================================================
--- head/sys/netinet/tcp_ratelimit.c	Thu Oct 29 22:14:34 2020	(r367146)
+++ head/sys/netinet/tcp_ratelimit.c	Thu Oct 29 22:16:59 2020	(r367147)
@@ -470,7 +470,6 @@ rl_attach_txrtlmt(struct ifnet *ifp,
 		error = ifp->if_snd_tag_alloc(ifp, &params, tag);
 #ifdef INET
 		if (error == 0) {
-			if_ref((*tag)->ifp);
 			counter_u64_add(rate_limit_set_ok, 1);
 			counter_u64_add(rate_limit_active, 1);
 		} else


More information about the svn-src-head mailing list