svn commit: r366993 - head/sys/net

Alexander Richardson arichardson at freebsd.org
Tue Oct 27 16:43:03 UTC 2020


On Sat, 24 Oct 2020 at 13:52, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>
> On Sat, Oct 24, 2020 at 10:23:22AM +0000, Hans Petter Selasky wrote:
> > New Revision: 366993
> > URL: https://svnweb.freebsd.org/changeset/base/366993
> >
> > Log:
> >   Run code through "clang-format -style=file" with some additional fixes.
> >   No functional change.
> >
> > ...
> > @@ -99,8 +97,8 @@ infiniband_ipv4_multicast_map(uint32_t addr,
> >
> >  #ifdef INET6
> >  static inline void
> > -infiniband_ipv6_multicast_map(const struct in6_addr *addr,
> > -    const uint8_t *broadcast, uint8_t *buf)
> > +infiniband_ipv6_multicast_map(
> > +    const struct in6_addr *addr, const uint8_t *broadcast, uint8_t *buf)
> >  {
>
> This is not how we format these in FreeBSD, please revert.  It was correct
> before and no "fix" is need here.
>
> ./danfe

Unfortunately this is a limitation of the current clang-format
version. I've submitted a patch upstream as
https://reviews.llvm.org/D90246 and the config file change is
https://reviews.freebsd.org/D26978.

Alex


More information about the svn-src-head mailing list