svn commit: r366993 - head/sys/net

[Alexander Richardson]

On Sat, 24 Oct 2020, 16:27 Warner Losh, <imp at bsdimp.com> wrote:

>
>
> On Sat, Oct 24, 2020, 7:38 AM Alexander V. Chernikov <melifaro at ipfw.ru>
> wrote:
>
>> 24.10.2020, 14:08, "Hans Petter Selasky" <hps at selasky.org>:
>> > On 2020-10-24 14:52, Alexey Dokuchaev wrote:
>> >>  On Sat, Oct 24, 2020 at 10:23:22AM +0000, Hans Petter Selasky wrote:
>> >>>  New Revision: 366993
>> >>>  URL: https://svnweb.freebsd.org/changeset/base/366993
>> >>>
>> >>>  Log:
>> >>>     Run code through "clang-format -style=file" with some additional
>> fixes.
>> >>>     No functional change.
>> >>>
>> >>>  ...
>> >>>  @@ -99,8 +97,8 @@ infiniband_ipv4_multicast_map(uint32_t addr,
>> >>>
>> >>>    #ifdef INET6
>> >>>    static inline void
>> >>>  -infiniband_ipv6_multicast_map(const struct in6_addr *addr,
>> >>>  - const uint8_t *broadcast, uint8_t *buf)
>> >>>  +infiniband_ipv6_multicast_map(
>> >>>  + const struct in6_addr *addr, const uint8_t *broadcast, uint8_t
>> *buf)
>> >>>    {
>> >>
>> >>  This is not how we format these in FreeBSD, please revert. It was
>> correct
>> >>  before and no "fix" is need here.
>> Given we already have nice .clang-format, that does most of the job,
>> maybe it's worth considering looking into tweaking it further to fix this
>> part?
>> It would be nice if we could finally offload all formatting issues to the
>> tool and focus on the actual code :-)
>>
>
> It would be nice if it produced one of the style(9) acceptable formats
> without disrupting things already acceptable.  That's been the big problem
> with the tweaks to date... some things are fixed, others break. It's
> getting a lot closer, though
>


I've upstreamed a few fixes, but haven't got to the line
wrapping/continuation indentation stuff yet. That part of clang format is
not particularly easy to modify without breaking other stuff and I'm also
rather short on time right now, so probably won't get to it any time soon.

Alex