svn commit: r366363 - head/sys/kern

Mateusz Guzik mjg at FreeBSD.org
Fri Oct 2 14:50:03 UTC 2020


Author: mjg
Date: Fri Oct  2 14:50:03 2020
New Revision: 366363
URL: https://svnweb.freebsd.org/changeset/base/366363

Log:
  cache: update the commentary for path parsing

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==============================================================================
--- head/sys/kern/vfs_cache.c	Fri Oct  2 14:00:52 2020	(r366362)
+++ head/sys/kern/vfs_cache.c	Fri Oct  2 14:50:03 2020	(r366363)
@@ -3948,10 +3948,10 @@ cache_fplookup_need_climb_mount(struct cache_fpl *fpl)
 /*
  * Parse the path.
  *
- * The code is mostly copy-pasted from regular lookup, see lookup().
- * The structure is maintained along with comments for easier maintenance.
- * Deduplicating the code will become feasible after fast path lookup
- * becomes more feature-complete.
+ * The code was originally copy-pasted from regular lookup and despite
+ * clean ups leaves performance on the table. Any modifications here
+ * must take into account that in case off fallback the resulting
+ * nameidata state has to be compatible with the original.
  */
 static int
 cache_fplookup_parse(struct cache_fpl *fpl)


More information about the svn-src-head mailing list