svn commit: r368072 - in head/contrib/bc: . gen include manuals manuals/bc manuals/dc src src/bc src/dc src/history src/rand tests

[Stefan Esser]

Am 26.11.20 um 21:03 schrieb Cy Schubert:> But this is still a problem:
> 
> ld: error: undefined symbol: bc_lib_name
>>>> referenced by vm.c:752 (/opt/src/svn-current/contrib/bc/src/vm.c:752)
>>>>                lto.tmp:(bc_vm_boot)
> 
> ld: error: undefined symbol: bc_lib
>>>> referenced by lex.c:225 (/opt/src/svn-current/contrib/bc/src/lex.c:225)
>>>>                lto.tmp:(bc_vm_boot)
>>>> referenced by lex.c:227 (/opt/src/svn-current/contrib/bc/src/lex.c:227)
>>>>                lto.tmp:(bc_vm_boot)
> cc: error: linker command failed with exit code 1 (use -v to see invocation)
> *** [gh-bc.full] Error code 1

I cannot reproduce this issue on my system.

The symbols are defined in files generated by gen/strgen.sh and
there was a change in the parameters passed to this script, but
I had fixed usr.bin/gh-bc/Makefile accordingly (first in the port
and then in base).

The generated file lib.c should start like this:
-----------------------------------------------------------------
// Copyright (c) 2018-2020 Gavin D. Howard and contributors.
// Licensed under the 2-clause BSD license.
// *** AUTOMATICALLY GENERATED FROM gen/lib.bc. DO NOT MODIFY. ***

#if 1
extern const char *bc_lib_name;

extern const char bc_lib[];

const char *bc_lib_name = "gen/lib.bc";

const char bc_lib[] =
"scale=20\n"
-----------------------------------------------------------------

This file is generated by this rule in usr.bin/gh-bc/Makefile:

lib.c:          lib.bc
                 cd ${BCDIR} && sh gen/strgen.sh gen/lib.bc 
${.OBJDIR}/lib.c bc_lib bc_lib_name 1 1

By a script that assigns parameters to variables:

input="$1"
output="$2"
name="$3"
label="$4"
define="$5"
remove_tabs="$6"

And label="bc_lib_name" is used to generate lib.c as included
above (passed as 4th parameter).

I'm rebuilding a clean world, now, but I'd be surprised if it failed
after succeeding before readying the commit ...

Regards, STefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20201126/76e91407/attachment.sig>