svn commit: r367538 - head/sys/arm64/arm64

Bjoern A. Zeeb bz at FreeBSD.org
Mon Nov 9 23:34:32 UTC 2020


Author: bz
Date: Mon Nov  9 23:34:32 2020
New Revision: 367538
URL: https://svnweb.freebsd.org/changeset/base/367538

Log:
  arm64: bs_sr_<N> take II
  
  In r367327 generic_bs_sr_<n> were derived from mips.  Given we are calling
  generic_bs_w_<n> and no write directly, we do not have to do the address
  calculations ourselves as eneric_bs_w_<n> will do a str val [bsh, offset].
  All we actually have to do is increment offset.
  
  MFC after:			3 days

Modified:
  head/sys/arm64/arm64/bus_machdep.c

Modified: head/sys/arm64/arm64/bus_machdep.c
==============================================================================
--- head/sys/arm64/arm64/bus_machdep.c	Mon Nov  9 23:05:28 2020	(r367537)
+++ head/sys/arm64/arm64/bus_machdep.c	Mon Nov  9 23:34:32 2020	(r367538)
@@ -136,40 +136,36 @@ static void
 generic_bs_sr_1(void *t, bus_space_handle_t bsh,
     bus_size_t offset, uint8_t value, size_t count)
 {
-	bus_addr_t addr = bsh + offset;
 
-	for (; count != 0; count--, addr++)
-		generic_bs_w_1(t, bsh, addr, value);
+	for (; count != 0; count--, offset++)
+		generic_bs_w_1(t, bsh, offset, value);
 }
 
 static void
 generic_bs_sr_2(void *t, bus_space_handle_t bsh,
 		       bus_size_t offset, uint16_t value, size_t count)
 {
-	bus_addr_t addr = bsh + offset;
 
-	for (; count != 0; count--, addr += 2)
-		generic_bs_w_2(t, bsh, addr, value);
+	for (; count != 0; count--, offset += 2)
+		generic_bs_w_2(t, bsh, offset, value);
 }
 
 static void
 generic_bs_sr_4(void *t, bus_space_handle_t bsh,
     bus_size_t offset, uint32_t value, size_t count)
 {
-	bus_addr_t addr = bsh + offset;
 
-	for (; count != 0; count--, addr += 4)
-		generic_bs_w_4(t, bsh, addr, value);
+	for (; count != 0; count--, offset += 4)
+		generic_bs_w_4(t, bsh, offset, value);
 }
 
 static void
 generic_bs_sr_8(void *t, bus_space_handle_t bsh, bus_size_t offset,
     uint64_t value, size_t count)
 {
-	bus_addr_t addr = bsh + offset;
 
-	for (; count != 0; count--, addr += 8)
-		generic_bs_w_8(t, bsh, addr, value);
+	for (; count != 0; count--, offset += 8)
+		generic_bs_w_8(t, bsh, offset, value);
 }
 
 struct bus_space memmap_bus = {


More information about the svn-src-head mailing list