svn commit: r362681 - in head: contrib/bc contrib/bc/gen contrib/bc/include contrib/bc/locales contrib/bc/manuals contrib/bc/src contrib/bc/src/bc contrib/bc/src/dc contrib/bc/src/history contrib/b...

[Stefan Eßer]

Am 27.06.20 um 23:52 schrieb Eric van Gyzen:
> On 6/27/20 8:11 AM, John Baldwin wrote:
>> On 6/27/20 5:02 AM, Stefan Eßer wrote:
>>> Author: se
>>> Date: Sat Jun 27 12:02:01 2020
>>> New Revision: 362681
>>> URL: https://svnweb.freebsd.org/changeset/base/362681
>>>
>>> Log:
>>>    Import new 2-clause BSD licenced implementation of the bc and dc
>>> commands
>>
>> Hmm, I didn't see a commit to add the vendor sources into ^/vendor
>> first via our
>> standard process for contrib sources, nor any discussion about that in
>> the review.
> 
> When you add this to the vendor area, please include the tests, to
> remove a barrier to integration.

Hi Eric,

I have already imported the full sources into the vendor area, including
the tests. These tests compare the output of this bc and dc with that of
GNU bc/dc and are run as regression tests by the author before a release
is tagged (and have been extended over time for each area where an issue
has been found). Extensive fuzzing is also performed to verify that the
low level math functions give correct results (again using another bc/dc
as reference), but we do not want to include those particular tests.

I'd like to make the tests available as regression tests in FreeBSD, but
have not looked at the best way to integrate them, yet. (The tests are
meant to be run within the source directory after building from sources
in place, for example, which is not at all what we do in FreeBSD.)


Independently of the issue of tests, I'm not sure about the best way to
proceed from the current situation with regard to what's in contrib/bc
now, and I have decided to leave the incomplete import untouched in
contrib/bc until I understand the best way forward.

I could delete what's currently in contrib/bc and use svn copy to make
the whole contents of vendor/bc/dist available in contrib/bc. The tests
require 1112 KB of space, while the rest of the sources takes up less
than 900 KB.

I could revert the full import to contrib/bc, but that would also revert
changes to e.g. usr.bin/Makefile and I'd rather remove just what's now
in contrib/bc and then use svn copy to make vendor/bc/dist available
there. The sources from the dist directory can be used unmodified, the
reason for cherry-picking was just that I did not want to import more
than is used at this time ...


I'd appreciate any advice given about what causes the least repo churn
and extra effort for the Git conversion.

Regards, STefan