svn commit: r362667 - head/sys/cddl/contrib/opensolaris/uts/common/dtrace

Enji Cooper yaneurabeya at gmail.com
Sat Jun 27 03:04:19 UTC 2020


> On Jun 26, 2020, at 6:02 PM, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> 
> On Sat, Jun 27, 2020 at 12:57:48AM +0000, Matt Macy wrote:
>> New Revision: 362667
>> URL: https://svnweb.freebsd.org/changeset/base/362667
>> 
>> Log:
>>  Fix "current" variable name conflict with openzfs
>> 
>>  The variable "current" is an alias for curthread
>>  in openzfs. Rename all variable uses of current
>>  in dtrace.c to curstate.
> 
> Shouldn't OpenZFS be fixed instead?  The fact that we need to fix our
> local variables suggests that they're abusing too generic name…


	I kind of agree with `current` being a bit too genericly named in both DTrace and OpenZFS :/..
Cheers,
-Enji



More information about the svn-src-head mailing list