svn commit: r361775 - in head/sys: dts/arm64/overlays modules/dtb/rpi

[Warner Losh]

On Thu, Jun 4, 2020 at 6:54 AM Rodney W. Grimes <freebsd at gndrsh.dnsmgr.net>
wrote:

> >
> > On 03/06/2020 19:59, Oleksandr Tymoshenko wrote:
> > > Rodney W. Grimes (freebsd at gndrsh.dnsmgr.net) wrote:
> > >> [ Charset UTF-8 unsupported, converting... ]
> > >>> Author: gonzo
> > >>> Date: Wed Jun  3 22:18:15 2020
> > >>> New Revision: 361775
> > >>> URL: https://svnweb.freebsd.org/changeset/base/361775
> > >>>
> > >>> Log:
> > >>>    Add spigen overlay for Raspberry Pi 4
> > >>>
> > >>>    Submitted by:  gergely.czuczy at harmless.hu
> > >>>
> > >>> Added:
> > >>>    head/sys/dts/arm64/overlays/spigen-rpi4.dtso   (contents, props
> changed)
> > >>> Modified:
> > >>>    head/sys/modules/dtb/rpi/Makefile
> > >>>
> > >>> Added: head/sys/dts/arm64/overlays/spigen-rpi4.dtso
> > >>>
> ==============================================================================
> > >>> --- /dev/null     00:00:00 1970   (empty, because file is newly
> added)
> > >>> +++ head/sys/dts/arm64/overlays/spigen-rpi4.dtso  Wed Jun  3
> 22:18:15 2020        (r361775)
> > >>> @@ -0,0 +1,30 @@
> > >>> +/* $FreeBSD$ */
> > >> This file needs some form of copyright/license.
> > > Whom should I put as a copyright folder, The FreeBSD Project or the
> > > person who submitted the patch?
> >
> > The person that submitted the patch.
> >
> > Note that the FreeBSD Project is not an entity and cannot hold
> > copyrights (The Foundation can but unless they sponsored it, that
> > usually involves paperwork).
>
> I am glad at least one other person understands that point in law:
>
> :root {1002}# find . -type f | xargs grep Copyright | grep -i freebsd |
> grep -i project
> ./cddl/compat/opensolaris/kern/opensolaris_dtrace.c: * Copyright 2014 The
> FreeBSD Project.
> ./net/if_enc.h: * Copyright (c) 2008 The FreeBSD Project.
> ./net/if_enc.c: * Copyright (c) 2006 The FreeBSD Project.
> ./kern/kern_idle.c: * Copyright (C) 2000-2004 The FreeBSD Project. All
> rights reserved.

./kern/subr_kdb.c: * Copyright (c) 2004 The FreeBSD Project
>

These should be changed to the actual author.


> ./conf/newvers.sh:      year=$(sed -Ee '/^Copyright .* The FreeBSD
> Project/!d;s/^.*1992-([0-9]*) .*$/\1/g' ${SYSDIR}/../COPYRIGHT)
> ./conf/newvers.sh: * Copyright (c) 1992-$year The FreeBSD Project.
> ./sys/copyright.h: * Copyright (C) 1992-2018 The FreeBSD Project. All
> rights reserved.
> ./sys/copyright.h:      "Copyright (c) 1992-2019 The FreeBSD Project.\n"
> ^^^  The copyright we spit out on every boot :-(
>

These four are fine. They were cleared by lawyers long ago. This is a point
that was extensively litigated during your absence and has been settled
practice for a long, long time. Those four instances and /COPYRIGHT are the
only places in the tree we should have this, however.

./compat/linux/linux_uid16.c: * Copyright (c) 2001  The FreeBSD Project
> ./tools/embed_mfs.sh:# Copyright (C) 2008 The FreeBSD Project. All rights
> reserved.
> ./dev/mfi/mfi_syspd.c: *            Copyright 1994-2009 The FreeBSD
> Project.
> ./dev/mfi/mfi_tbolt.c: *            Copyright 1994-2009 The FreeBSD
> Project.
> ./dev/chromebook_platform/chromebook_platform.c: * Copyright (c) 2016 The
> FreeBSD Project.
> ./dev/pccard/pccarddevs: * Copyright (c) 1999-2004 The FreeBSD Project.
> ./dev/tdfx/tdfx_linux.c: * Copyright (c) 2006 The FreeBSD Project
> ./powerpc/powerpc/uma_machdep.c: * Copyright (c) 2003 The FreeBSD Project
> ./libkern/memset.c: * Copyright (C) 1992-2007 The FreeBSD Project. All
> rights reserved.
>

These are also not fine and should be similarly changed.

It would be a great project for someone to do the svn diving and find who
committed those files originally and correct it.

Warner


> >
> > Pedro.
> >
> >
>
> --
> Rod Grimes
> rgrimes at freebsd.org
>