svn commit: r363679 - in head: contrib/netbsd-tests/lib/libc/regex/data lib/libc/regex

[Kyle Evans]

On Thu, Jul 30, 2020 at 6:48 AM Gordon Bergling <gbe at freebsd.org> wrote:
>
> On Thu, Jul 30, 2020 at 01:26:46PM +0200, Stefan Eßer wrote:
> > Am 30.07.20 um 01:21 schrieb Kyle Evans:
> > [...]
> > >   This change bumps the symbol version of regcomp to FBSD_1.6 and provides the
> > >   old escape semantics for legacy applications, just in case one has an older
> > >   application that would immediately turn into a pumpkin because of an
> > >   extraneous escape that's embedded or otherwise critical to its operation.
> >
> > I get an error during make buildworld with option WITH_TESTS=yes:
> >
> > ===> usr.bin/bmake/tests (install)
> > ld-elf.so.1: /usr/src/amd64.amd64/tmp/legacy/usr/sbin/make: Undefined
> > symbol "regcomp at FBSD_1.6"
> >
> > Regards, STefan
>
> I got the same error this morning and was able to solve it by doing a full
> buildworld without NO_CLEAN=yes.
>
> You may want to try this in case you are using NO_CLEAN=yes.
>

This is interesting; there shouldn't be any NO_CLEAN implications with
this change. There were no dependency changes, libc should definitely
get rebuilt because regcomp.c changed and thus, the libc in your
objdir should have the symbol. The binary referenced above is one that
we symlink into OBJDIR from the host system.

I think it's also likely your problem was just fixed by the second
installworld. The first one will manage to get libc installed, but not
before you get errors from all the other stuff.

Thanks,

Kyle Evans