svn commit: r357269 - head/usr.bin/tip/tip

Dimitry Andric dim at FreeBSD.org
Wed Jan 29 21:07:46 UTC 2020


Author: dim
Date: Wed Jan 29 21:07:46 2020
New Revision: 357269
URL: https://svnweb.freebsd.org/changeset/base/357269

Log:
  Merge r357267 from the clang1000-import branch:
  
  Fix the following -Werror warning from clang 10.0.0 in tip:
  
  usr.bin/tip/tip/tip.c:428:4: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation]
                          if (gch == EOF)
                          ^
  usr.bin/tip/tip/tip.c:426:5: note: previous statement is here
                  } else if (!cumode && gch == character(value(FORCE)))
                    ^
  
  The intent was to have the EOF check grouped with the getchar() call
  just above it.  This was accidentally introduced in r354624.
  
  MFC after:	3 days

Modified:
  head/usr.bin/tip/tip/tip.c
Directory Properties:
  head/   (props changed)

Modified: head/usr.bin/tip/tip/tip.c
==============================================================================
--- head/usr.bin/tip/tip/tip.c	Wed Jan 29 21:06:22 2020	(r357268)
+++ head/usr.bin/tip/tip/tip.c	Wed Jan 29 21:07:46 2020	(r357269)
@@ -423,11 +423,12 @@ tipin(void)
 			if (boolean(value(HALFDUPLEX)))
 				printf("\r\n");
 			continue;
-		} else if (!cumode && gch == character(value(FORCE)))
+		} else if (!cumode && gch == character(value(FORCE))) {
 			gch = getchar();
 			if (gch == EOF)
 				return;
 			gch = gch & STRIP_PAR;
+		}
 		bol = any(gch, value(EOL));
 		if (boolean(value(RAISE)) && islower(gch))
 			gch = toupper(gch);


More information about the svn-src-head mailing list