svn commit: r356262 - head/sys/kern

Pawel Biernacki kaktus at FreeBSD.org
Thu Jan 2 01:23:43 UTC 2020


Author: kaktus
Date: Thu Jan  2 01:23:43 2020
New Revision: 356262
URL: https://svnweb.freebsd.org/changeset/base/356262

Log:
  sysctl: hide 2.x era compat node
  
  r23081 introduced kern.dummy oid as a semi ABI compat for kern.maxsockbuf
  that was moved to a new namespace.  It never functioned as an alias of any
  kind and was just returning 0 unconditionally, hence it was probably
  provided to keep some 3rd party programmes happy about sysctl(3) not
  reporting an error because of non-existing oid.
  After nearly 23 years it seems reasonable to just hide it from sysctl(8)
  list not to cause unnecessary confusion as for its purpose.
  
  Reported by:	Antranig Vartanian <antranigv at freebsd.am>
  Reviewed by:	kib (mentor)
  Approved by:	kib (mentor)
  Differential Revision:	https://reviews.freebsd.org/D22982

Modified:
  head/sys/kern/uipc_sockbuf.c

Modified: head/sys/kern/uipc_sockbuf.c
==============================================================================
--- head/sys/kern/uipc_sockbuf.c	Wed Jan  1 22:51:17 2020	(r356261)
+++ head/sys/kern/uipc_sockbuf.c	Thu Jan  2 01:23:43 2020	(r356262)
@@ -1522,7 +1522,7 @@ sbtoxsockbuf(struct sockbuf *sb, struct xsockbuf *xsb)
 
 /* This takes the place of kern.maxsockbuf, which moved to kern.ipc. */
 static int dummy;
-SYSCTL_INT(_kern, KERN_DUMMY, dummy, CTLFLAG_RW, &dummy, 0, "");
+SYSCTL_INT(_kern, KERN_DUMMY, dummy, CTLFLAG_RW | CTLFLAG_SKIP, &dummy, 0, "");
 SYSCTL_OID(_kern_ipc, KIPC_MAXSOCKBUF, maxsockbuf, CTLTYPE_ULONG|CTLFLAG_RW,
     &sb_max, 0, sysctl_handle_sb_max, "LU", "Maximum socket buffer size");
 SYSCTL_ULONG(_kern_ipc, KIPC_SOCKBUF_WASTE, sockbuf_waste_factor, CTLFLAG_RW,


More information about the svn-src-head mailing list