svn commit: r358417 - head/sys/cam

[Warner Losh]

On Thu, Feb 27, 2020, 6:27 PM Benjamin Kaduk <bjkfbsd at gmail.com> wrote:

> On Thu, Feb 27, 2020 at 5:18 PM Warner Losh <imp at freebsd.org> wrote:
>
>> Author: imp
>> Date: Fri Feb 28 01:18:11 2020
>> New Revision: 358417
>> URL: https://svnweb.freebsd.org/changeset/base/358417
>>
>> Log:
>>   This is a FALLTHROUGH for sure. no need for xxx comment.
>>
>> Modified:
>>   head/sys/cam/cam_xpt.c
>>
>> Modified: head/sys/cam/cam_xpt.c
>>
>> ==============================================================================
>> --- head/sys/cam/cam_xpt.c      Fri Feb 28 01:02:01 2020        (r358416)
>> +++ head/sys/cam/cam_xpt.c      Fri Feb 28 01:18:11 2020        (r358417)
>> @@ -2690,7 +2690,7 @@ xpt_action_default(union ccb *start_ccb)
>>         case XPT_NVME_ADMIN:
>>                 /* FALLTHROUGH */
>>         case XPT_MMC_IO:
>> -               /* XXX just like nmve_io? */
>> +               /* FALLTHROUGH */
>>         case XPT_RESET_DEV:
>>         case XPT_ENG_EXEC:
>>         case XPT_SMP_IO:
>>
>>
> Okay, I'll bite.  Why do XPT_NVME_ADMIN and XPT_MMC_IO get "FALLTHROUGH"
> comments but XPT_RESET_DEV and XPT_ENG_EXEC just get listed as part of the
> same grouping as XPT_SMP_IO?
>

Good question.  I just fixed a dubious xxx comment, but you mat be right.


Warner

>