svn commit: r358257 - in head/sys: kern sys

Kyle Evans kevans at freebsd.org
Sun Feb 23 03:53:23 UTC 2020


On Sat, Feb 22, 2020 at 9:32 PM Ryan Libby <rlibby at freebsd.org> wrote:
>
> Author: rlibby
> Date: Sun Feb 23 03:32:11 2020
> New Revision: 358257
> URL: https://svnweb.freebsd.org/changeset/base/358257
>
> Log:
>   vfs: quiet -Wwrite-strings
>
>   Reviewed by:  kib, markj
>   Differential Revision:        https://reviews.freebsd.org/D23797
>

Only tangentially related to this, I have a patch in one of my WIP
branches that const-poisons vn_fullpath()'s retbuf parameter, if
that's of any interest. Many consumers will set a default value to a
statically allocated string before passing it in as the retbuf -- I
had a use-case where I'd be trying to do similar but with a function
that actually returns a const char *, but that particular case may not
get committed.

I can post the patch to phabricator if anyone cares about this -- the
impact on callers isn't actually all that bad, basically just
shuffling around declarations. There's only one case where it ends up
introducing some __DECONST ugliness because the caller writes it out
with uiomove().

Thanks,

Kyle Evans


More information about the svn-src-head mailing list